Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: Warning container in call #18442

Merged
merged 1 commit into from
Dec 6, 2024
Merged

revert: Warning container in call #18442

merged 1 commit into from
Dec 6, 2024
+30 −70

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Dec 6, 2024

Description

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@przemvs przemvs requested review from otto-the-bot and a team as code owners December 6, 2024 10:58
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.34%. Comparing base (02854ae) to head (d37f852).
Report is 15 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #18442      +/-   ##
==========================================
- Coverage   46.34%   46.34%   -0.01%     
==========================================
  Files         846      845       -1     
  Lines       26372    26373       +1     
  Branches     5979     5980       +1     
==========================================
  Hits        12223    12223              
- Misses      12617    12621       +4     
+ Partials     1532     1529       -3

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@przemvs przemvs merged commit fd52dbe into dev Dec 6, 2024
13 checks passed
@przemvs przemvs deleted the revert/warning-container-in-call branch December 6, 2024 11:23
@paulwire paulwire added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafsulich olafsulich olafsulich approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@przemvs @codecov-commenter @olafsulich @otto-the-bot @paulwire